From: Andre Przywara Date: Mon, 12 Dec 2011 17:43:15 +0000 (+0000) Subject: xl: fix compiler warnings X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=0eefd1091284ac85e403cbe68ed133b51b7f046a;p=xen.git xl: fix compiler warnings either GCC 4.6.1 or Ubuntu add -Werror=format-security to the -Wall set, so libxl compilation breaks: libxl_create.c: In function 'store_libxl_entry': libxl_create.c:454:9: error: format not a string literal and no format arguments [-Werror=format-security] cc1: all warnings being treated as errors Attached patch fixes this and another occurrence. Patch from: Uwe Dannowski Signed-off-by: Andre Przywara Acked-by: Ian Jackson Committed-by: Ian Jackson --- diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index ce6a55e959..648615600c 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -461,7 +461,7 @@ static int store_libxl_entry(libxl__gc *gc, uint32_t domid, path = libxl__xs_libxl_path(gc, domid); path = libxl__sprintf(gc, "%s/dm-version", path); - return libxl__xs_write(gc, XBT_NULL, path, libxl__strdup(gc, + return libxl__xs_write(gc, XBT_NULL, path, "%s", libxl__strdup(gc, libxl_device_model_version_to_string(dm_info->device_model_version))); } diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c index a53fb70837..1db395c116 100644 --- a/tools/libxl/libxl_device.c +++ b/tools/libxl/libxl_device.c @@ -516,7 +516,7 @@ int libxl__devices_destroy(libxl__gc *gc, uint32_t domid, int force) for (j = 0; j < num_devs; j++) { path = libxl__sprintf(gc, "/local/domain/%d/device/%s/%s/backend", domid, kinds[i], devs[j]); - path = libxl__xs_read(gc, XBT_NULL, libxl__sprintf(gc, path)); + path = libxl__xs_read(gc, XBT_NULL, libxl__sprintf(gc, "%s", path)); if (path && libxl__parse_backend_path(gc, path, &dev) == 0) { dev.domid = domid; dev.kind = kind;